mlir: ease the interoperability with a local LLVM checkout - #128
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
qaco
force-pushed
the
hugo/llvm-local-interop
branch
from
September 4, 2026 16:02
e8c55cb to
67be1de
Compare
guillon
reviewed
Sep 7, 2026
guillon
left a comment
guillon
left a comment
Member
There was a problem hiding this comment.
Seems fine, but see comments, I will add @liamsemeria to the review for checking the local MLIR and xtc_transform stuff
| for name in Optimizers.names(): | ||
| print(f"{name}") | ||
|
|
||
| def _warmup_llvm_backends(self) -> None: |
Member
There was a problem hiding this comment.
Not sure of the intention there, though there is an old ordering of the backends which order import of mlir backend before import of tvm backend above in the config post init. Can you check if it's still required?:
def __post_init__(self):
...
# Workaround to ensure that TVM backend is after MLIR backends,
# otherwise the import of tvm breaks the MLIR python bindings
self.backends = sorted(self.backends)
Contributor
Author
There was a problem hiding this comment.
Yeah I changed the order in post_init and removed my warmup
qaco
force-pushed
the
hugo/llvm-local-interop
branch
from
September 7, 2026 11:41
f6ea98f to
c03176d
Compare
guillon
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Being able to evaluate the impact of upstream changes (or patches to upstream) on XTC codegen.
Description
Encapsulate the XTC extensions to MLIR bindings, discard deprecated options, warmup TVM before the other backends (in loop-explore).